[fix](hudi) fix hudi scan problem#51489
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 33968 ms |
TPC-DS: Total hot run time: 192468 ms |
ClickBench: Total hot run time: 28.82 s |
englefly
approved these changes
Jun 4, 2025
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
hubgeter
pushed a commit
to hubgeter/doris
that referenced
this pull request
Jun 16, 2025
### What problem does this PR solve? Related PR: apache#51329 Problem Summary: The `LogicalHudiScan` class should overload the method `withOperativeSlots` and return the `LogicalHudiScan` type. Otherwise, the `LogicalFileScanToPhysicalFileScan` rule will be incorrectly applied when querying the hudi table, resulting in the generation of `PhysicalFileScan`. Because `plan` is `LogicalFileScan`, `plan -> !(plan instanceof LogicalHudiScan)` will incorrectly return true. ```java public class LogicalFileScanToPhysicalFileScan extends OneImplementationRuleFactory { @OverRide public Rule build() { return logicalFileScan().when(plan -> !(plan instanceof LogicalHudiScan)).then(fileScan -> new PhysicalFileScan( fileScan.getRelationId(), fileScan.getTable(), fileScan.getQualifier(), DistributionSpecAny.INSTANCE, Optional.empty(), fileScan.getLogicalProperties(), fileScan.getSelectedPartitions(), fileScan.getTableSample(), fileScan.getTableSnapshot(), fileScan.getOperativeSlots()) ).toRule(RuleType.LOGICAL_FILE_SCAN_TO_PHYSICAL_FILE_SCAN_RULE); } } ``` (cherry picked from commit df06507)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #51329
Problem Summary:
The
LogicalHudiScanclass should overload the methodwithOperativeSlotsand return theLogicalHudiScantype. Otherwise, theLogicalFileScanToPhysicalFileScanrule will be incorrectly applied when querying the hudi table, resulting in the generation ofPhysicalFileScan.Because
planisLogicalFileScan,plan -> !(plan instanceof LogicalHudiScan)will incorrectly return true.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)